Disable efficiency cores #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuupke
requested changes
Jul 30, 2025
| @@ -61,14 +94,18 @@ if [ -d $DIR_INTEL ]; then | |||
| # increase freq from powersaving to normal, but don't overclock | |||
| echo 100 > $DIR_INTEL/min_perf_pct | |||
| echo 100 > $DIR_INTEL/max_perf_pct | |||
| elif [ -d $DIR_AMD ]; then | |||
| elif [ -f $FILE_AMD && ]; then | |||
There was a problem hiding this comment.
This looks incorrect to me, but I don't use bash often enough to be sure.
| echo "Error: turboboost still enabled!" | ||
| exit 1 | ||
| fi | ||
| else | ||
| echo "Warning: kernel (turbo) boost config not found in '$DIR_INTEL' or '$DIR_AMD'." | ||
| fi | ||
|
|
||
| if [ -n "${store_isolcpus_fact}" ]; then |
There was a problem hiding this comment.
Is it on purpose that this is not logged when turboboost cannot be disabled? This is an improvement nonetheless, but probably best to move this to before disabling turboboost.
We will use those later for a report and to not duplicate the method of disabling.
This is defence in depth by disallowing the kernel to schedule work on the online cpu's before the script disables the CPU's. The script can fail when the CPU taken down is currently working on something.
Package is more correct but socket is better known. Also fixed a typo.
The boost exists for asahi@M1 laptops but not on a raspberry with ARMv7.
Also clarified the package/socket as package is more correct but socket is better known and fixed a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarified the package/socket as package is more correct but socket is better known and fixed a typo.
This does not fix our issue yet but will most likely help us a bit more.