Test the configure script in fedora #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +34,9 @@ setup() { | |||
| for shared_file in config.log confdefs.h conftest.err; do | |||
| chmod a+rw $shared_file || true | |||
| done | |||
| if grep "fedora" /etc/os-release 2>/dev/zero >&2; then | |||
There was a problem hiding this comment.
Can use $disto_id here as well? And some places below
vmcj
force-pushed
the
configure_test_fedora
branch
2 times, most recently
from
bc6de37
to
a413a52
Compare
nickygerritsen
approved these changes
Jul 30, 2023
We only test fedora as that is what is being used by atleast 1 site. Red
Hat {8,9} don't have cgroup-devel so already require more work for the
user so we don't test those.
Fedora uses another group for webservers
vmcj
force-pushed
the
configure_test_fedora
branch
from
b2997f1
to
3836bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora is the only flavour for Red Hat which we can support for judgehosts (due to the libcgroup development files). Testing this in every CI seems to be waste of time so only test in main or release branches.
This did uncover a typo and a bug where we don't detect the nginx group, a fix for both is added.