Show elapsed minutes on scoreboard #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks a bit cluttered IMHO. Don't have a great idea though that's better than this. |
I can put it behind a config flag if that is better. |
eldering
reviewed
Sep 3, 2023
| started: | ||
| {{ current_contest.starttime | printelapsedminutes(now) }} at |
There was a problem hiding this comment.
I'd prefer to keep it simple and use printtimediff here. That also renders something like 221 minutes more readably as 3:41.
There was a problem hiding this comment.
I think the point was to show exactly 221 minutes since you don't need to do further math to relate to the numbers in the scoreboard.
|
This should be updated based on whats in the linked issue. |
vmcj
force-pushed
the
scoreboard_show_time_remaining
branch
from
77d0b6b
to
26fd96b
Compare
vmcj
force-pushed
the
scoreboard_show_time_remaining
branch
from
26fd96b
to
73b959e
Compare
vmcj
force-pushed
the
scoreboard_show_time_remaining
branch
from
b4baf75
to
cfad1a5
Compare
meisterT
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be an implementation for: #2064
There is a micro optimization to deduplicate the
nowby merging the last elseif...else and than introducing an if, I found that less readable and moving thisnowhigher would trigger this always for every scoreboard and given that its a public page that felt annoying.I'm not sure if the
printremainingminutes&printelapsedminutesshouldn't be merged with a boolean flag to keep them together, now they are basically each others inverse.