Add option to hide nonloggedin/nonsubmitted teams on the scoreboard #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO closes: #2061 |
meisterT
reviewed
Sep 1, 2023
etc/db-config.yaml
Outdated
| @@ -269,6 +269,15 @@ | |||
| default_value: false | |||
| public: true | |||
| description: Show canonical compiler and runner version on the team pages. | |||
| - name: hide_teams_scoreboard_condition | |||
There was a problem hiding this comment.
Consider phrasing these in a positive form, e.g. show_teams_on_scoreboard: always, after_login, after_submission
Note that the autologin tool should only set last API login, not last UI login. |
nickygerritsen
approved these changes
Sep 1, 2023
I thought so but I was not sure, but still I think people can come up with an usecase for both. I'm fine with making this a boolean but than I need to know which one we prefer. |
|
I think the 3 options are totally fine. |
As discussed in Slack, I'll also fix the issue where when you use only the submit client I'll still put you on the scoreboard as you did a login via the API (but need to see if I should check for users with !(GUI OR submission) or on both login fields (and get the GEHACK scenario) |
|
I'll fix it tonight and wait for @ubergeek42 if this is indeed a fix to his issue. |
|
This sounds like it'd fix the issue we saw at NAC |
vmcj
force-pushed
the
hide_teams_login_submission
branch
from
119859e
to
8b47fb9
Compare
Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team
Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
vmcj
force-pushed
the
hide_teams_login_submission
branch
from
8b47fb9
to
51f5364
Compare
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Jul 25, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Jul 26, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Aug 5, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Aug 5, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Aug 5, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Aug 5, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
tom93
pushed a commit
to tom93/domjudge
that referenced
this pull request
Aug 15, 2024
… scoreboard (DOMjudge#2134) * Add option to hide nonloggedin/nonsubmitted teams on the scoreboard Done as a config option for the following 2 cases: - Normally you want a team which has logged on on the scoreboard - In case of the autologin tool of GEHACK/Nicky the user would also login without interaction of the actual team * Allow API logon as the submit client uses it Alternative would be to UNION over teams which submitted and teams which did a GUI logon but that is more expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a config option as a config option for the following 2 cases:
I've tested it manually and it works.