Show unused executables as disabled #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,9 +40,22 @@ public function __construct( | |||
| protected readonly EventLogService $eventLogService | |||
| ) {} | |||
|
|
|||
| private function checkDisabled(Executable $e): bool | |||
There was a problem hiding this comment.
This should be checkEnabled if it returns true when enabled. Also maybe move this to the executable.php file?
vmcj
force-pushed
the
executables_table_endisabled
branch
from
3ed7761
to
d2c55ec
Compare
|
This has suggestions from both @meisterT & @nickygerritsen as I had split an earlier PR over 2 different branches to find the actual issue. |
nickygerritsen
approved these changes
Oct 4, 2023
This needs to be further extended as language executables are now shown as disabled.
vmcj
force-pushed
the
executables_table_endisabled
branch
from
d2c55ec
to
affc0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits over 2 tables, it does not mark the executable of languages (labeled as no submit) as disabled (yet).