Fix handling of mysql passwords with weird characters in it #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldering
force-pushed
the
fix-mysql-password
branch
2 times, most recently
from
169aa03
to
ba630f7
Compare
vmcj
reviewed
Aug 25, 2024
eldering
force-pushed
the
fix-mysql-password
branch
from
ba630f7
to
0dc1deb
Compare
eldering
force-pushed
the
fix-mysql-password
branch
from
0dc1deb
to
9f12b77
Compare
eldering
force-pushed
the
fix-mysql-password
branch
2 times, most recently
from
0dc1deb
to
0cb10aa
Compare
See for reference: - https://dev.mysql.com/doc/refman/8.0/en/connecting-using-uri-or-key-value-pairs.html#connecting-using-uri - https://symfony.com/doc/current/doctrine.html but note that we must use `rawurlencode` instead of `urlencode` which differ in how they encode a space (as tested). Fixes: #2651 Closes: #2502 as this is likely fixed but I couldn't reproduce it
There was no easy way to do this, besides also completely dropping and recreating an empty database.
Use URL encoding in DATABASE_URL and return mysql_options as an array (via ugly global variable), so each element in it can be separately added to the command line using `@` for expansion.
eldering
force-pushed
the
fix-mysql-password
branch
from
0cb10aa
to
e371261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password is passed inside the environment variable
DATABASE_URLwhich is URI-like. However, it must be URL encoded there if it contains any strange characters, like a space,%, etc.Also add a handy command
dj_setup_database update-passwordthat reset the MySQL database user password to what it currently inetc/dbpassword.secret, and handle weird passwords in this script. This script is now bash, and should probably be rewritten in PHP or so.