[Feature] 상품 상세 조회 기능 구현 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kyeong-hyeok
requested changes
Sep 12, 2023
| import com.teamA.hicardi.domain.item.entity.ItemImage; | ||
|
|
||
| public interface ItemImageRepository extends JpaRepository<ItemImage, Long> { | ||
| List<ItemImage> findItemImagesByItemId(Long itemId); |
There was a problem hiding this comment.
findByItemId로 바꿔도 괜찮 ㅎㅎ 상관없지만~
| @Operation(summary = "상품 상세 조회", description = "상품을 조회합니다.", | ||
| security = { @SecurityRequirement(name = "bearer-key") }, | ||
| responses = { | ||
| @ApiResponse(responseCode = "200", description = "상품 상세 조회 성공") |
There was a problem hiding this comment.
ErrorResponse도 스웨거 명세에 넣으면 좋을 듯함
kyeong-hyeok
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #53
📝 작업 내용
상품 상세 조회 기능 구현
💬 리뷰 요구 사항
리뷰 부탁드립니다.