Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 공지사항 전체 조회 기능 구현 #64

Merged
merged 7 commits into from
Sep 15, 2023

Conversation

pdohyung
Copy link
Member

💡 연관된 이슈

close #63

📝 작업 내용

공지사항 전체 조회 기능 구현

💬 리뷰 요구 사항

@pdohyung pdohyung added the ✨ Feature 기능 개발 label Sep 14, 2023
@pdohyung pdohyung linked an issue Sep 14, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@kyeong-hyeok kyeong-hyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋았습니다.


private final NoticeService noticeService;

@GetMapping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스웨거 명세 설명 에러 메세지 포함해서 추가하면 좋을 듯 합니다.

@kyeong-hyeok kyeong-hyeok merged commit 669a84e into develop Sep 15, 2023
1 check passed
@kyeong-hyeok kyeong-hyeok deleted the feature/63-notice-all-get branch September 15, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 공지사항 전체 조회 기능 구현
2 participants