Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce automatic language detection in TesseractOcrCliModel #800

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

nikos-livathinos
Copy link
Collaborator

Introduce automatic language detection for the TesseractOcrCliModel.
The language detection mode is enabled when lang == "auto"

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

…el. Extend unit tests.

Signed-off-by: Nikos Livathinos <[email protected]>
@nikos-livathinos nikos-livathinos marked this pull request as draft January 24, 2025 10:28
Copy link

mergify bot commented Jan 24, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

dolfim-ibm
dolfim-ibm previously approved these changes Jan 24, 2025
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nikos-livathinos nikos-livathinos self-assigned this Jan 24, 2025
@nikos-livathinos nikos-livathinos marked this pull request as ready for review January 24, 2025 11:40
@nikos-livathinos nikos-livathinos marked this pull request as draft January 24, 2025 14:02
…ate if the auto-detected

language is installed in the system and if not fall back to a default option without language.

Signed-off-by: Nikos Livathinos <[email protected]>
@nikos-livathinos nikos-livathinos marked this pull request as ready for review January 24, 2025 21:33
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterStaar-IBM PeterStaar-IBM merged commit 3be2fb5 into main Jan 26, 2025
9 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the nli/tesseract_cli_lang_detection branch January 26, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants