No ticket: wrap all pinwheel_account accesses in a check for its presence

[millerti]

No ticket: wrap all pinwheel_account accesses in a check for its presence

Resolves NewRelic alert from 12/05/24

Changes

The alert seems to have happened because only two of the three accesses of the pinwheel_account object were predicated on 'if pinwheel_account.present?' but the third was not. This ticket wraps all these calls in an if that checks the same predicate to help protect from this problem in the future.

Testing

Not quite sure how to test this. Would it just be going through the workflow and making it past the pinwheel loading screen?

Acceptance testing

• No acceptance testing needed
  • This change will not affect the user experience (bugfix, dependency updates, etc.)
• Acceptance testing prior to merge
  • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
  • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
• Acceptance testing after merge
  • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
  • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud