Wmg write upload #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthesignals
force-pushed
the
wmg-write-upload
branch
from
872c487 to
fd1c8bb
Compare
allthesignals
commented
Feb 1, 2024
Comment on lines
-109
to
-123
|
|
||
| # Confirms Storybook still builds successfully | ||
| check-storybook-builds: | ||
| name: Build check - Storybook | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| cache-dependency-path: ${{ env.LOCKFILE_PATH }} | ||
| cache: ${{ env.PACKAGE_MANAGER }} | ||
| - run: npm ci | ||
| - run: npm run storybook-build |
There was a problem hiding this comment.
Not sure this was useful for us so removed it but could add it back later... it's currently broken
allthesignals
commented
Feb 1, 2024
| @@ -4,7 +4,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "build": "next build", | |||
| "dev": "next dev", | |||
| "dev": "NODE_OPTIONS='--inspect' next dev", | |||
There was a problem hiding this comment.
Nice for chrome devtools inspection
allthesignals
commented
Feb 1, 2024
| bodyParser: { | ||
| sizeLimit: "10mb", | ||
| }, | ||
| bodyParser: false, |
There was a problem hiding this comment.
turn off bodyParser to allow Formidable to do its thing
Merged
|
I think I must be doing something wrong, but I'm running the workflow where I upload a small jpg and:
|
|
@millerti what's your node version? |
|
Per discussion, this now works as described. It does seem to bury the file in /var instead of /tmp so maybe just update the description? |
millerti
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
{LINK TO TICKET}
Changes
Writes the uploaded file to the os' tmp directory and prints the written file path in the console