A corner case handling #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that last modification time of the "target" is after the last modification time of the source file/director,This can handled by using the inbuilt absolute function `abs`.
| @@ -40,7 +40,7 @@ def size_if_newer(source, target): | |||
|
|
|||
| # The time difference of one second is necessary since subsecond accuracy | |||
| # of os.st_mtime is striped by copy2 | |||
| return src_stat.st_size if (src_stat.st_mtime - target_ts > 1) else False | |||
| return src_stat.st_size if abs(src_stat.st_mtime - target_ts > 1) else False | |||
There was a problem hiding this comment.
@kumar-mahendra I think you meant to say the below line :-
return src_stat.st_size if (abs(src_stat.st_mtime - target_ts) > 1) else False
Taking the absolute first and then comparing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that last modification time of the "target" is after the last modification time of the source file/directory,This can handled by using the inbuilt absolute function
abs.