Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugins' main.py to update isc-agent.sqlite #265

Closed
wants to merge 1 commit into from

Conversation

port0x50
Copy link
Contributor

NOTE: Recommend testing before committing to ensure formatting is correct and this exhibits the intended behavior. While this change does write to the db file, if the isc-agent is restarted it appears to wipe the local db (/srv/db/isc-agent.sqlite).

  • change commits logs to the sqlite file so user can query

- change commits logs to the sqlite file
@port0x50
Copy link
Contributor Author

image

Here is how the request_log looks if queried

Copy link
Contributor

@jullrich jullrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be needed. It looks like you:

  • select the logs from the database
  • add them again to the database after you read them

this code would just duplicate the logs I think. will not include it for now until I get to look at it closer.

@port0x50
Copy link
Contributor Author

Agreed. This isn't the correct approach for this particular issue.

@port0x50 port0x50 closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants