Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing focus indicators #3084

Closed
hostle83 opened this issue May 29, 2024 · 1 comment · Fixed by #3065
Closed

Missing focus indicators #3084

hostle83 opened this issue May 29, 2024 · 1 comment · Fixed by #3065
Assignees
@alexandrevryghem
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system
Milestone
9.0

Comments

@hostle83
Copy link

Describe the bug
When navigating the sandbox or demo site by keyboard-only, two instances are showing a missing focus indicator:

  1. The search icon in the utility navigation:
    image

  2. The hierarchical tree view:
    image

To Reproduce
Steps to reproduce the behavior:

  1. Navigate the demo or sandbox site by keyboard only.

Expected behavior
According to SC 2.4.7 Focus Visible (Level AA) (https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html), a vertical bar should be displayed in the field, indicating that the user can insert text. This happens, when the user clicks (or hits enter) on the search icon, but not before

In the hierarchical tree view, there is are no focus elements around the subject categories when navigating with keyboard only.
@hostle83 hostle83 added bug needs triage New issue needs triage and/or scheduling labels May 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog May 29, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward accessibility component: Discovery related to discovery search or browse system and removed needs triage New issue needs triage and/or scheduling labels May 29, 2024
@alexandrevryghem
Copy link
Member

@hostle83: I was able to reproduce the error in the search facets, currently there is a deadlock preventing to access that link so I added that fix to this PR. For the first issue I can see a focus indicator on the latest version of DSpace, so could you perhaps check if this still happens for you?

@alexandrevryghem alexandrevryghem mentioned this issue Jun 22, 2024
Merged
8 tasks
@alexandrevryghem alexandrevryghem self-assigned this Jun 22, 2024
@alexandrevryghem alexandrevryghem added claimed: Atmire Atmire team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward labels Jun 22, 2024
@tdonohue tdonohue added e/10 Estimate in hours and removed e/10 Estimate in hours labels Jun 27, 2024
@github-project-automation github-project-automation bot moved this from 📋 To Do to ✅ Done in DSpace 8.x and 7.6.x Maintenance Dec 10, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandrevryghem alexandrevryghem

Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system
Projects
DSpace 8.x and 7.6.x Maintenance
Status: ✅ Done
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Made AdminSearchPageComponent themeable alexandrevryghem/dspace-angular
3 participants
@tdonohue @hostle83 @alexandrevryghem