Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ePerson link on edit group page #2662

Conversation

alexandrevryghem
Copy link
Member

References

Description

Since the creation of the new separate ePerson pages the ePerson route includes the id of the ePerson. This PR now fixes this route in both the display ePerson tab & the search ePerson tab on the edit group page.

Instructions for Reviewers

List of changes in this PR:

  • Fixed the link on edit group for both the display ePerson tab & the search ePerson tab
  • Removed the now unused method EPersonDataService.getEPeoplePageRouterLink() since it's better to use getEPersonsRoute() directly

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Nov 23, 2023
@alexandrevryghem alexandrevryghem added bug authorization related to authorization, permissions or groups medium priority claimed: Atmire Atmire team is working on this issue & will contribute back and removed medium priority labels Nov 23, 2023
@alexandrevryghem alexandrevryghem force-pushed the fix-eperson-link-on-group-pages_contribute-main branch from b44a8b3 to 430ee38 Compare November 23, 2023 20:33
@alexandrevryghem alexandrevryghem added this to the 8.0 milestone Nov 23, 2023
@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 27, 2023
@alanorth
Copy link
Contributor

Thanks @alexandrevryghem! I noticed this bug today and thought it must be something with my setup.

I tested this patch on DSpace 7.6.1 and it fixes the problem.

@tdonohue this seems to be a pretty straightforward patch. Can this be 1 APPROVAL?

@tdonohue
Copy link
Member

@alanorth : Yes, I agree this should be 1 Approval. Looks like this was just overlooked. Adding the label now. Feel free to merge/backport if you find it's working well.

@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jan 11, 2024
@tdonohue tdonohue requested a review from alanorth January 11, 2024 20:29
@alanorth alanorth merged commit c55d518 into DSpace:main Jan 12, 2024
12 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@alanorth alanorth removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Jan 12, 2024
@alexandrevryghem alexandrevryghem deleted the fix-eperson-link-on-group-pages_contribute-main branch May 15, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug claimed: Atmire Atmire team is working on this issue & will contribute back
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Clicking on a member, redirects to user search
4 participants