Fix whitespace in links due to newlines #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorth
added
low priority
ux
alanorth
changed the title
The newlines cause whitespace to be enapsulated in the rendered link.
The newlines cause whitespace to be enapsulated in the rendered link.
alanorth
force-pushed
the
fix-community-cdk-tree-links
branch
from
15a6ee2 to
7207bbb
Compare
|
Added another fix for browse links. Before:
After:
|
alanorth
added
the
1 APPROVAL
|
Assuming this is uncontroversial so adding |
nwoodward
approved these changes
Jan 18, 2024
|
Successfully created backport PR for |
alanorth
removed
the
port to dspace-7_x
|
Thanks @nwoodward. It's due to whitespace being inside the anchor tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Fix erroneous whitespace inside link text in community-list cdk tree and browse definition links.
Instructions for Reviewers
Build the frontend and make sure the links on
/community-listlook and work as expected.List of changes in this PR:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.