Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCID Registry Queue table: Fix behavior on item removal from the table #3463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alisaismailati
Copy link
Contributor

References

Description

Fixes include refactor the ORCID queue component (orcid-queue.component.ts) to update pagination options not only when changing pages (handled by the pagination component) but also when items are removed from the table. Additionally, eliminate the flickering behavior on item removal.

Instructions for Reviewers

List of changes in this PR:

  • The first refactor involves storing data in a component variable and, upon deletion, removing the element from the list without making another call to retrieve data.
  • If the last element on the page is removed, navigate to the previous page by updating the current page in the pagination options and reflecting it in the URL. This way we may retrieve the remaining data for that new page.
  • Additionally, handle the fragment to scroll into view (table) on page change, as the pagination component's fragment handling was not working correctly in this case. This way when we change the page of the table, we will be repositioned again to the table.

Include guidance for how to test or review your PR.
Steps described on #3462

Result:
(p.s test is done using dummy data for the publications)

orcid-queue.mp4

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alisaismailati alisaismailati marked this pull request as ready for review October 17, 2024 10:56
@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge integration: ORCID Related to integration with ORCID identifier system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug integration: ORCID Related to integration with ORCID identifier system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

ORCID Registry Queue table becomes empty when all items on the last page are unlinked
2 participants