Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to angular v18 #3717

Open
wants to merge 125 commits into
base: main
Choose a base branch
from
Open

Upgrade to angular v18 #3717

wants to merge 125 commits into from
+7,609 −7,369

Conversation

AAwouters
Copy link
Contributor

@AAwouters AAwouters commented Dec 6, 2024 •
edited
Loading

References

This branch continues on the work of #3506 which makes it look like this PR contains a lot more commits than it actually does. This compare view shows only the commits that belong to this PR.

Description

Updates Angular to version 18.
Dependencies related to Angular are also updated.

Instructions for Reviewers

This PR does not include any new functionality. Test DSpace as you usually would.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

LotteHofstede and others added 30 commits August 28, 2024 13:26
@LotteHofstede
117631: upgraded bootstrap, ng-bootstrap and installed popper.js
f8e1e58
@ybnd @LotteHofstede
117631: SASS to CSS variables
de513ba
@LotteHofstede
117631: Bootstrap 4 to 5 html/css fixes
cc9c158
@LotteHofstede
117631: Theming fixes after bootstrap upgrade
6e13b4b
@LotteHofstede
117631: More theming fixes: accordions, spacing, search components etc
76920dc
@LotteHofstede
117631: Fixed tests
d877d65
@LotteHofstede
117631: Fixed offset issues
b32b850
@LotteHofstede
117631: Fixed contrast ratio issue
37eb758
@LotteHofstede
117631: Fixed variables, removed unnecessary mapping, fixed tables, u…
8eeb0f4 
…pgraded to Bootstrap 5.3.3
@Wout-atmire
118113: vertical footer deviders
fecb39c
@Wout-atmire
118113: remove button shadow
0b287b7
@Wout-atmire
118113: old checkboxes
f95276e
@Wout-atmire
118113: Custom icons font-family
9ad28a0
@Wout-atmire
118113: accordion color
bbb14cf
@Wout-atmire
118113: table striped customizable background-color
98ce20f
@Wout-atmire
118113: revert vertical deviders in footer bs-secondary change
75d51b0
@Wout-atmire
118113: modal close button
2bf113d
@Wout-atmire
118113: add w-100 to btn-block elements
ca588e8
@Wout-atmire
118113: border radius
d616b06
@Wout-atmire
118113: The date selector on the submission page gets squished to the…
b23e758 
… side of its label fix
@Wout-atmire
118113: adding margins to dynamic-form-control-containers
8d264dc
@Wout-atmire
118113: adding gaps between sections of item submission form
759038b
@Wout-atmire
118113: icon font-family removed !important
4b10994
@Wout-atmire
118113: removed !important from #legend_dc_date_issued
28b838c
@Wout-atmire
118113: move --bs-border-radius to $bs-border-radius
3ac4858
@Wout-atmire
118113: remove new SCSS variable
b8e9340
@Wout-atmire
118113: reduce size for Item type labels
758c3aa
@Wout-atmire
118113: date picker border - transparent
b3c5d94
@Wout-atmire
118113: drag-item-container elements on same line
586f5ea
@Wout-atmire
118113: specific border color for ds-number-picker buttons
4ce65dd
@Wout-atmire
Merge branch 'w2p-120594_fix-bootstrap5-feedback' into w2p-118627_rea…
90474f9 
…lign-standard-dspace-themes-after-bootstrap-5-upgrade-9.0
@github-actions GitHub Actions
Copy link

Hi @AAwouters,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@nwoodward nwoodward mentioned this pull request Dec 19, 2024
Open
Wout-atmire and others added 14 commits February 21, 2025 14:35
@Wout-atmire
Merge remote-tracking branch 'ds/main' into w2p-118627_realign-standa…
85d9bb2 
…rd-dspace-themes-after-bootstrap-5-upgrade-9.0
@Wout-atmire
120594: fix white badges
c49289e
@Wout-atmire
118627: remove shadow on number-picker
8507066
@Wout-atmire
120594: revert white badge fix
8ebd4fa
@Wout-atmire
120594: re-add dropdown-button in dynamic-lookup-relation-search-tab
d60d797
@Wout-atmire
120594: remove default radio button styling
730db27
@Wout-atmire
120594: full width radio buttons
55fb78a
@Wout-atmire
120594: edit collection page alignment
3dd435e
@Wout-atmire
120594: bg -> bg-primary
4eb6307
@Wout-atmire
120594: revert to old info color
a8a3d54
@Wout-atmire
120594: revert media breakpoints
a27ea98
@Wout-atmire
120594: recover PR 3227 rss
c1d9cfc
@AAwouters
Merge branch 'w2p-118627_realign-standard-dspace-themes-after-bootstr…
1fb66b7 
…ap-5-upgrade-9.0' into w2p-120243_Upgrade-to-Angular-v18

# Conflicts:
#	package-lock.json
#	package.json
@AAwouters
Merge branch 'main' into w2p-120243_Upgrade-to-Angular-v18
add615a
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Hi @AAwouters,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue
Copy link
Member

tdonohue commented Mar 5, 2025

@AAwouters : Can you please rebase this on the latest main code now that #3506 is merged? Currently, this PR is showing merge conflicts and over 120 commits. If you rebase this, then only the commits specific to this Angular 18 upgrade should be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue Awaiting requested review from tdonohue

@atarix83 atarix83 Awaiting requested review from atarix83

At least 1 approving review is required to merge this pull request.

Assignees

@AAwouters AAwouters

Labels
dependencies Pull requests that update a dependency file high priority merge conflict new feature
Projects
DSpace 9.0 Release
Status: 👀 Under Review
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 18
5 participants
@AAwouters @tdonohue @LotteHofstede @ybnd @Wout-atmire