-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(frontend): add document type field on primary identification screen #192
Merged
faiza-jahanzeb
merged 1 commit into
main
from
faiza/primary-identification-screen-with-document-type
Feb 11, 2025
Merged
(frontend): add document type field on primary identification screen #192
faiza-jahanzeb
merged 1 commit into
main
from
faiza/primary-identification-screen-with-document-type
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-comeau
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd need to experiment with it, but I think using a single validation and returning all errors to the component, even if the entire form isn't displayed, could work. The "step" logic might not be necessary.
a496d21
to
ebff13c
Compare
65ed56b
to
1b92733
Compare
gregory-j-baker
previously approved these changes
Feb 11, 2025
sebastien-comeau
requested changes
Feb 11, 2025
56db634
to
853ac9b
Compare
sebastien-comeau
requested changes
Feb 11, 2025
853ac9b
to
877a2bf
Compare
877a2bf
to
4d971ae
Compare
4d971ae
to
d7f6685
Compare
sebastien-comeau
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work item: #14682
Add document type field on primary identification screen
User is presented with the Current Status options. Based on the correct options "Canadian citizen born outside Canada" or "Registered Indian born in Canada" in current status, the document type show respective options.
On pressing next button, field is validated. Correct validation for proof of concept is "Canadian citizen born outside Canada"
The document type is validated for null value.
Types of changes
What types of changes does this PR introduce?
(check all that apply by placing an
x
in the relevant boxes)Checklist
Before submitting this PR, ensure that you have completed the following. You can fill these out now, or after creating the PR.
(check all that apply by placing an
x
in the relevant boxes)Linting and formatting
Unit and e2e tests
npm run test npm run test:e2e