WIP: MultiSelect

[a-thansen]

Progress Report

06/11

Bugs:

• minimizing windows to less than 712 px window width leads to navbar squashing
• selecting >2 condition indicators always defaults to the data shown in screenshot

Features to add:

• Allow for a select all functionality instead of 'ALL'

[a-thansen]

This should be done now and ready for use w plots for example, made a new issue concerning the data bug in the description and etc. #106

[marcosantiagomuro]

so I suppose that when we select ALL to should be equal to having KPI + IRI + DI + E_norm, right?

KPI + IRI + DI + E-norm:

ALL:

apparently ALL shows even more indicators? is it correct?

[marcosantiagomuro]

looks very smooth, I don't know what ALL should mean, if it includes parameters that we don't show in the dropdown menu than it wouldn't make that much sense in my opinion (so we should add also those). if instead it is only a problem that the existing parameters are not shown then it's fixable somewhere I suppose

[marcosantiagomuro]

I pulled and now with mu seems to be working (?) :)

[marcosantiagomuro]

also maybe there is a layering problem?

If I first select KPI:

then I add IRI. which adds it to the layer of KPI:
so if on the same road segments where a KPI was taken we have an IRI value, the IRI just goes on "top" of it.

but actually IRI has more road segments than KPI, but I think that for some layering options it stays hidden.

also if we have both KPI and IRI do the colours add up ?

because KPI has only red, IRI only yellow,
but together we can also see some green

[a-thansen]

looks very smooth, I don't know what ALL should mean, if it includes parameters that we don't show in the dropdown menu than it wouldn't make that much sense in my opinion (so we should add also those). if instead it is only a problem that the existing parameters are not shown then it's fixable somewhere I suppose

I'm thinking in the next version of multi-select, I'll incorporate a select all feature which would allow all the conditions to be auto-selected, or setting up a feature that when you select "ALL" the rest of the options cannot be selected

[Seb-sti1]

I add a comment to reduce the complicatedness but that's not a big deal

[Seb-sti1]

I add a comment to reduce the complicatedness but that's not a big deal

Sorry I forgot to add that I remembered recently that we shouldn't be creating functions in Functional Component in React. The most likely alternative in our case would be useCallback see this https://stackoverflow.com/questions/46138145/where-should-functions-in-function-components-go

[Seb-sti1]

🚀