This repository has been archived by the owner on May 4, 2024. It is now read-only.
69 map road same view #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosantiagomuro
added
feature
|
I think some dependencies were not installed correctly(?) |
Yes, It should be fixable with |
Seb-sti1
reviewed
Nov 6, 2023
| @@ -6,7 +6,6 @@ interface TopBarProps { | |||
| /** | |||
| * The toggle button value | |||
| */ | |||
| isToggleOn: React.Dispatch<React.SetStateAction<boolean>>; | |||
There was a problem hiding this comment.
You can remove the whole props
Comment on lines
-49
to
-56
| <div className="toggle-container"> | ||
| <div className="toggle-label"> | ||
| <span className="toggle-text">Map mode</span> | ||
| <label className="toggle-switch"> | ||
| <input type="checkbox" onChange={handleToggleMiddleArea} /> | ||
| <span className="slider"></span> | ||
| </label> | ||
| <span className="toggle-text">Road mode</span> |
There was a problem hiding this comment.
Could you remove the unused classes from the css files?
| @@ -62,26 +61,29 @@ const RoadDetails = () => { | |||
| }, []); | |||
|
|
|||
| return ( | |||
| <div> | |||
| <TopBar isToggleOn={setShowRoadImageMode} /> | |||
| <div className="div-mapAndRoad-container"> | |||
There was a problem hiding this comment.
is the class div-mapAndRoad-container exists in the css files?
There was a problem hiding this comment.
I added it only so when I did the inspect on the page I could recognise the div
There was a problem hiding this comment.
should I remove the className?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created split component in inspect page, with map, road surface image and graph