Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

95 zoom able image #104

Merged
merged 4 commits into from
Nov 9, 2023
Merged

95 zoom able image #104

merged 4 commits into from
Nov 9, 2023

Conversation

zoi23333
Copy link
Contributor

@zoi23333 zoi23333 commented Nov 5, 2023

The old pull request messed up by some of my operations so created this new one.
Some redundant code before caused by the arrows not displaying properly. The issues have been fixed, and comments have also been added.

@zoi23333 zoi23333 self-assigned this Nov 5, 2023
Copy link
Contributor

@Sol2526 Sol2526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Zoi :). I think this is great. The only thing I've noticed is that the exit button slides along with the horizontal slider on the x axis:

image

The same for the right arrow button:

image

Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and thanks for taking the comments from the other MR in consideration. Hope you did not have too much trouble with git...

frontend/src/Components/RoadDetails/ImageAbleZoom.tsx Outdated Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageAbleZoom.tsx Outdated Show resolved Hide resolved
@Seb-sti1
Copy link
Contributor

Seb-sti1 commented Nov 6, 2023

I also have the same bug as Sol with the sliders but not for the cross and the navigation, so it's probably related somehow to the size of the screen.

@Seb-sti1 Seb-sti1 added feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page labels Nov 6, 2023
@Seb-sti1 Seb-sti1 added this to the Release 2 milestone Nov 6, 2023
@Seb-sti1 Seb-sti1 linked an issue Nov 6, 2023 that may be closed by this pull request
@zoi23333
Copy link
Contributor Author

zoi23333 commented Nov 7, 2023

Hey Zoi :). I think this is great. The only thing I've noticed is that the exit button slides along with the horizontal slider on the x axis:

image The same for the right arrow button: image

Thank you. I have fixed this and submitted a new pull request, Please take a look at your convenience

Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have still a

frontend/src/css/road_details.css Outdated Show resolved Hide resolved
frontend/src/css/road_details.css Show resolved Hide resolved
Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think you changed anything, don't you?

@zoi23333
Copy link
Contributor Author

zoi23333 commented Nov 9, 2023

don't think you changed anything, don't you?

I found the commit I updated yesterday somehow didn't appear in gitHub earlier, but now when I fetch origin to check, it appeared. that's weird.
Now you can check it.😊

Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the same issue... I think we won't have it for R2

@zoi23333
Copy link
Contributor Author

zoi23333 commented Nov 9, 2023

I still have the same issue... I think we won't have it for R2

Fair enough, we can change it later.

@Seb-sti1
Copy link
Contributor

Seb-sti1 commented Nov 9, 2023

I still have the same issue... I think we won't have it for R2

Fair enough, we can change it later.

Might have made a mistake on my end, will check again in a sec

@Seb-sti1 Seb-sti1 merged commit 4fe95dc into dev Nov 9, 2023
6 checks passed
@Seb-sti1 Seb-sti1 deleted the 95-ZoomAbleImage branch November 9, 2023 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageGallery: Add possibility to zoom in images
3 participants