Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

show dash cam images nearby to current location #168

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

marcosantiagomuro
Copy link
Contributor

so I added some logic in order to display only the DashCam images that are next to location

but for each image we have distance_survey (is it relative value? )and distance_way (is it in meters? ) but still the values seem a bit weird

@marcosantiagomuro marcosantiagomuro self-assigned this Dec 12, 2023
@marcosantiagomuro marcosantiagomuro added frontend Frontend related Inspect map Features related to the inspect map page labels Dec 12, 2023
@marcosantiagomuro
Copy link
Contributor Author

for example with distance_survey in survey_5 it works quite good in my opinion but with the other surveys data is incosistent

@marcosantiagomuro
Copy link
Contributor Author

marcosantiagomuro commented Dec 17, 2023

so now seems to be working:

for example distanceLEftToRight is : 18.9 - 21.8 m

image

and it shows the 3 images images at distances 15, 20, 25 m

in the logic I put -5m to + 5m of the road we are showing in RoadSurfaceImages

@marcosantiagomuro
Copy link
Contributor Author

Screen.Recording.2023-12-17.at.23.03.12.mov

@marcosantiagomuro
Copy link
Contributor Author

now it should be working merge it fi you want, I might open a super small PR to hide the image gallery when there are no photos (I was thinking through a callback function from imageGallery component to see if he fetches any images data ), but have some things to do so might do it on the 20th or 21st

@marcosantiagomuro marcosantiagomuro added this to the Release 4 (final) milestone Dec 18, 2023
Copy link
Contributor

@a-thansen a-thansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and good idea w removing image gallery but let's see if we have time

@marcosantiagomuro marcosantiagomuro merged commit 5af00be into dev Dec 18, 2023
6 checks passed
@marcosantiagomuro marcosantiagomuro deleted the 151-display-nearby-dashCameras branch December 18, 2023 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frontend Frontend related Inspect map Features related to the inspect map page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DashCamera should only show images close to the user current position
2 participants