Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Gallery changes. Smooth scroll, small button changes, etc. #68

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Gallery changes. Smooth scroll, small button changes, etc. #68

merged 7 commits into from
Oct 25, 2023

Conversation

Sol2526
Copy link
Contributor

@Sol2526 Sol2526 commented Oct 12, 2023

No description provided.

@Seb-sti1 Seb-sti1 self-requested a review October 12, 2023 21:14
@Seb-sti1 Seb-sti1 added feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page labels Oct 12, 2023
@Seb-sti1 Seb-sti1 added this to the Release 2 milestone Oct 12, 2023
@Seb-sti1 Seb-sti1 linked an issue Oct 12, 2023 that may be closed by this pull request
Image Gallery: test of a new version of the layout #61
Closed
Seb-sti1
Seb-sti1 suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline is failing with some prettier issues, using npx prettier -w . should fix those (also activate "format on save" in VS code so that it's done automatically)

If you have any question, just answer the comments and i will answer as soon as possible

frontend/src/Components/RoadDetails/ImageGallery.tsx Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Outdated Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Outdated Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Outdated Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Show resolved Hide resolved
frontend/src/Components/RoadDetails/ImageGallery.tsx Show resolved Hide resolved
Seb-sti1
Seb-sti1 suggested changes Oct 19, 2023
View reviewed changes
frontend/src/Components/RoadDetails/ImageGallery.tsx Outdated Show resolved Hide resolved
.github/workflows/documentation.yml Outdated Show resolved Hide resolved
@Seb-sti1 Seb-sti1 linked an issue Oct 20, 2023 that may be closed by this pull request
ImageGallery: Prevent slider to go after images #73
Closed
3 tasks
@Seb-sti1
Copy link
Contributor

Could you squash everything before merging?

@Sol2526 Sol2526 added this pull request to the merge queue Oct 25, 2023
Merged via the queue into dev with commit f541efd Oct 25, 2023
6 checks passed
@Seb-sti1 Seb-sti1 deleted the img-gallery-changes branch October 25, 2023 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Seb-sti1 Seb-sti1 Seb-sti1 approved these changes

@zoi23333 zoi23333 Awaiting requested review from zoi23333

@marcosantiagomuro marcosantiagomuro Awaiting requested review from marcosantiagomuro

Assignees

@Sol2526 Sol2526

Labels
feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page
Projects
None yet
Milestone
Release 2
Development

Successfully merging this pull request may close these issues.

ImageGallery: Prevent slider to go after images Image Gallery: test of a new version of the layout
2 participants
@Sol2526 @Seb-sti1