This repository has been archived by the owner on May 4, 2024. It is now read-only.
Rework conditionsmap #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb-sti1
added
feature
|
Link to #53 |
Seb-sti1
commented
Oct 19, 2023
There was a problem hiding this comment.
Everything seems good to me! @a-thansen if you want to merge the TopBar before my branch (so that I will do the rebase), it's possible 😃
5 tasks
Merge for topbar is ready ! Just waiting for review on the top bar pull req. and then I can get this merged! |
Seb-sti1
force-pushed
the
rework-conditionsmap
branch
2 times, most recently
from
3a65031
to
c43a05d
Compare
- Move topbar in the Conditions.tx - Move css import in right files - Optimize and simplify ConditionsMap.tsx Cleanup page files - Rename Main and Inspect - Remove unused - Align backend calls
Seb-sti1
force-pushed
the
rework-conditionsmap
branch
from
c43a05d
to
c500ed1
Compare
Seb-sti1
commented
Nov 4, 2023
a-thansen
reviewed
Nov 6, 2023
a-thansen
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should now be a lot easier to understand the file and what is done in it :-)! I also removed some unused things