Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Info button #93

Closed
wants to merge 5 commits into from
Closed

Info button #93

wants to merge 5 commits into from

Conversation

Sol2526
Copy link
Contributor

@Sol2526 Sol2526 commented Nov 2, 2023

I've added an info button and panel. Panel spawns on the left of the info button and it has a fade-in/fade-out effect. User and press the arrow down button on the top right of the panel to scroll down to the bottom or just use scroll wheel. The scroll rect should be invisible on all browsers.

image

@Sol2526 Sol2526 requested a review from Seb-sti1 November 2, 2023 20:35
@Sol2526 Sol2526 self-assigned this Nov 2, 2023
@Sol2526 Sol2526 linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Made few comments

@zoi23333 plz review when you can

frontend/src/Components/Conditions/InfoButton.tsx Outdated Show resolved Hide resolved
frontend/src/Components/Conditions/InfoButton.tsx Outdated Show resolved Hide resolved
frontend/src/Components/Conditions/InfoButton.tsx Outdated Show resolved Hide resolved
frontend/src/css/InfoButton.css Show resolved Hide resolved
frontend/src/pages/Conditions.tsx Outdated Show resolved Hide resolved
@Seb-sti1 Seb-sti1 added feature New feature or request frontend Frontend related Main map Features related to the main map page Inspect map Features related to the inspect map page labels Nov 4, 2023
@Seb-sti1 Seb-sti1 added this to the Release 2 milestone Nov 4, 2023
@Sol2526
Copy link
Contributor Author

Sol2526 commented Nov 6, 2023

image

Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every is good to me here, I will let @zoi23333 review and approve it :)

@a-thansen
Copy link
Contributor

@Sol2526 Looks ready to be merged after a rebase on dev, and a few minor changes :))

@zoi23333
Copy link
Contributor

zoi23333 commented Nov 9, 2023

Yeeees, it's also good for me. Just if we want it better, might can uniform font size and line spacing later.
Sorry for the late reply, I might had too many emails from another course to make the messages down😂. I'll check fast next time.
And the number of files changed now is 206, coz our main brach(dev) have changed these days. This branch need to be rebased. My way is backup the files of this branch, then fetch the latest main branch. create a new branch to add/modify the backup files again. Then create a new pull branch. (I am not sure if there is other better way)

Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't add the node_modules, package.json and package-lock.json in the root of the repo

@Sol2526 Sol2526 closed this Nov 10, 2023
@Sol2526 Sol2526 deleted the info-button branch November 10, 2023 08:32
@Sol2526 Sol2526 removed a link to an issue Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page Main map Features related to the main map page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants