Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Simpler status endpoint" #30

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Revert "Simpler status endpoint" #30

merged 1 commit into from
Nov 1, 2024

Conversation

plasorak
Copy link
Collaborator

@plasorak plasorak commented Nov 1, 2024

Reverts #27 in conjunction with DUNE-DAQ/drunc#296

@plasorak plasorak requested a review from bieryAtFnal November 1, 2024 12:56
bieryAtFnal
bieryAtFnal approved these changes Nov 1, 2024
View reviewed changes
Copy link

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran successfully with these changes (and the corresponding ones in drunc) with several automated regression tests and a simple interactive session.

@plasorak plasorak merged commit 96099b2 into develop Nov 1, 2024
1 check passed
@plasorak plasorak deleted the revert-27-plasorak/status branch November 1, 2024 13:33
@plasorak plasorak mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bieryAtFnal bieryAtFnal bieryAtFnal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plasorak @bieryAtFnal