-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled the warning messages about too many digits for TR numbers #84
Disabled the warning messages about too many digits for TR numbers #84
Conversation
…uence number, since we now realize we want the config params to specify the minimum number of digits not a fixed number of digits.
To test this, I used steps similar to numbers 1-6 on this page, then I edited the generated
then I ran |
…no_warnings_hdf5_digits
src/HDF5FileLayout.cpp
Outdated
@@ -67,7 +67,7 @@ HDF5FileLayout::get_record_number_string(uint64_t record_number, // NOLINT(build | |||
int width = m_conf_params.digits_for_record_number; | |||
|
|||
if (record_number >= m_powers_ten[m_conf_params.digits_for_record_number]) { | |||
ers::warning(FileLayoutNotEnoughDigitsForPath(ERS_HERE, record_number, m_conf_params.digits_for_record_number)); | |||
//ers::warning(FileLayoutNotEnoughDigitsForPath(ERS_HERE, record_number, m_conf_params.digits_for_record_number)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for either removing this line entirely, or perhaps making it a TLOG_DEBUG so we still have visibility when the minimum is insufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Eric suggested, I removed the lines entirely. (And, in fact, I took the opportunity to remove a few more lines of unnecessary code.)
Commented out the warnings about too many digits for TR number and sequence number, since we now realize we want the config params for them to specify the minimum number of digits not a fixed number of digits.
Also, changed the documentation strings in the schema for the relevant config params to sa that the params specify the minimum number of digits.
In the future, we may change the name of the config params to have "minimum" in them, but we won't do that now, in the spirit of minimizing changes