Changes to help avoid warning messages when tardy TPs arrive at the TPStreamWriter #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 2, 2024 09:05
…Header DataSet as a single string. This will be used to check if a TSH already exists for a given time slice and not waste time trying to create it again.
…TestDumpRecord output so that expert users can verify that the correct number is present.
…esn't try to write a TimeSlice that already exists. It now throws a special exception instead so that callers can react appropriately.
…tpsw_ignore_late_tps
wesketchum
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to ones in
daqdataformatsanddfmodules, but it can be regression tested and merged by itself.These changes are part of reducing the number of warning messages when tardy TPs arrive at the TPStreamWriter.
The changes in this package basically consist of checking whether a TimeSlice has already been written to the HDF5 file, and throwing a custom exception when that happens so that the code that calls
write(TimeSlice)can react intelligently.The change in HDF5LIBS_TestDumpRecord is not related to the TPSW changes, but is just a convenience that is being included here for expedience.