Glm/mlt #293
Merged
Glm/mlt #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturSztuc
approved these changes
Apr 4, 2024
| << pending_td.readout_start << "/" << pending_td.readout_end; | ||
| //m_td_paused_tc_count += pending_td.contributing_tcs.size(); | ||
| TLOG_DEBUG(1) << "Triggers are paused. Not sending a TriggerDecision for TD with timestamp and type " | ||
| << ts << "/" << tt; |
There was a problem hiding this comment.
The type is a bitword (there can be multiple TCs of different types in TD), and I'm not sure if auto appreciates it, or just converts e.g. 000100010 (say, prescale & Timing types in this TD) to e.g. 34 (meaningless to reader).
Doesn't need to be resolved in this PR though, though maybe a TODO comment could be useful.
| TLOG_DEBUG(1) << "The DFO is busy. Not sending a TriggerDecision for candidate timestamp " | ||
| << pending_td.contributing_tcs[m_earliest_tc_index].time_candidate; | ||
| TLOG_DEBUG(1) << "The DFO is busy. Not sending a TriggerDecision with timestamp and type " | ||
| << ts << "/" << tt; |
| return ignore; | ||
| } | ||
|
|
||
| std::bitset<16> |
There was a problem hiding this comment.
Thinking out loud, all these 16s will need to be changed to 64s when merging v4 into develop.
I think v4 and v5 diverged so much, that maybe there's some motivation to NOT do a standard v4 merge into develop, and instead just re-implement whatever v4 features we had into v5 from scratch. It might be easier...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLT restructuring (goes together with appdal schema changes)