Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CIB #295

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

nbarros
Copy link

@nbarros nbarros commented Apr 10, 2024

This PR adds in the CIB as a new HSI-like object capable of generating Trigger Candidates. The code is largely based on the CTB code, with a few caveats for the possibility of having multiple insteances if the CIBModule to feed HSIEvents.

By default the CIB is not enabled, and therefore this code should not affect previous operation.

edit: Just as a note, ran the minimal_system_quick_test.py integration test with all the CIB related code and everything was fine.

@nbarros nbarros mentioned this pull request Apr 10, 2024
4 tasks
@ArturSztuc ArturSztuc added the enhancement New feature or request label Apr 10, 2024
@bieryAtFnal bieryAtFnal added the miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable label Apr 10, 2024
Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in so far as existing integtests continue to run successfully.

@bieryAtFnal bieryAtFnal merged commit 694c642 into DUNE-DAQ:prep-release/fddaq-v4.4.0 Apr 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants