This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Allows using renovate.json as file to update baseBranches
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nches` property with `release`
DaRaFF
suggested changes
Sep 7, 2023
| @@ -6,7 +6,7 @@ const argv = require('yargs') | |||
| type: 'string' | |||
| }) | |||
| .option('file', { | |||
There was a problem hiding this comment.
the script only supports README.md or renovate.json, so I would add the .choices param (didn't test it out)
.option('file', {
description: 'append empty space to README.md or update renovate.json (one needs a file diff to create a bump PR)',
type: 'string',
choices: ['README.md', 'renovate.json']
})There was a problem hiding this comment.
I was thinking that you can add a new line in any file (doesn't have to be README.md) but we can limit the script to just work with README.md or renovate.json. I will try with choices :)
| const newLineReadmeEncoded = Buffer.from(newLineReadme).toString('base64') | ||
| let newContent | ||
| if (file === "renovate.json") { | ||
| // Replace baseBranches with new release branch |
There was a problem hiding this comment.
can you extend the comment and describe how it looks before and after?
|
|
||
| // create new release-branch | ||
| const branchName = `bump-to-next-minor-version-${Date.now()}` | ||
| const branchName = `bump-to-next-minor-version-${release}` |
There was a problem hiding this comment.
the consequence is that you can only do 1 bump per release (which is most probably ok).
JordiVM
changed the title
renovate.json as file to update baseBranchesrenovate.json as file to update baseBranches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the steps that we have to do in the release, I believe it would be useful to automate and unify some steps. In this case, we need to update the
renovate.jsonin master branch, so it would be useful to do that instead of adding a new line in README.md