-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular Evacuation #818
base: master
Are you sure you want to change the base?
Modular Evacuation #818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point of No Return has been removed, this changes behavior.
Discussed on discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary pre-test examination. Mostly looks good though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more information/descriptivity to the 15 separate identical stack traces that the runtime viewer will end up bundling together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, my fault for being insufficiently descriptive.
This should be the last major change before I feel comfortable running a round with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just needs testing.
About The Pull Request
This PR intends to make evacuation less hardcoded to allow for other ways of evacuation depending on the map.
Why It's Good For The Game
It gives a lot more freedom for the mapper (provided they find a coder to code a gamemode). For example a ship in deep space doesn't need a shuttle to fly from somewhere, you can have it docked at the ship from the beginning.
Changelog
🆑
add: Evacuation is now modular allowing new ways of evacuation
del: Removed shuttle hijacking objective
del: Removed shuttle catastrophe and shuttle insurance events
config: Added LOG_EVACUATION entry
config: Renamed EMERGENCY_SHUTTLE_AUTOCALL_THRESHOLD to EVACUATION_AUTOCALL_THRESHOLD
/:cl: