Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular Evacuation #818

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

DTraitor
Copy link
Contributor

About The Pull Request

This PR intends to make evacuation less hardcoded to allow for other ways of evacuation depending on the map.

Why It's Good For The Game

It gives a lot more freedom for the mapper (provided they find a coder to code a gamemode). For example a ship in deep space doesn't need a shuttle to fly from somewhere, you can have it docked at the ship from the beginning.

Changelog

🆑
add: Evacuation is now modular allowing new ways of evacuation
del: Removed shuttle hijacking objective
del: Removed shuttle catastrophe and shuttle insurance events
config: Added LOG_EVACUATION entry
config: Renamed EMERGENCY_SHUTTLE_AUTOCALL_THRESHOLD to EVACUATION_AUTOCALL_THRESHOLD
/:cl:

Copy link
Member

@francinum francinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point of No Return has been removed, this changes behavior.

Discussed on discord.

@francinum francinum mentioned this pull request Mar 2, 2024
Copy link
Member

@francinum francinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary pre-test examination. Mostly looks good though.

code/datums/evacuation_controllers/emergency_shuttle.dm Outdated Show resolved Hide resolved
code/game/gamemodes/dynamic/dynamic.dm Outdated Show resolved Hide resolved
code/__DEFINES/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/modules/antagonists/highlander/highlander.dm Outdated Show resolved Hide resolved
code/modules/antagonists/revolution/enemy_of_the_state.dm Outdated Show resolved Hide resolved
code/modules/antagonists/revolution/enemy_of_the_state.dm Outdated Show resolved Hide resolved
code/modules/antagonists/wishgranter/wishgranter.dm Outdated Show resolved Hide resolved
code/modules/mob/dead/new_player/new_player.dm Outdated Show resolved Hide resolved
@DTraitor DTraitor requested a review from francinum March 11, 2024 19:56
Copy link
Member

@francinum francinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information/descriptivity to the 15 separate identical stack traces that the runtime viewer will end up bundling together.

code/game/gamemodes/dynamic/dynamic.dm Show resolved Hide resolved
Copy link
Member

@francinum francinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, my fault for being insufficiently descriptive.

This should be the last major change before I feel comfortable running a round with this.

code/controllers/subsystem/evacuation.dm Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/evacuation.dm Outdated Show resolved Hide resolved
@DTraitor DTraitor requested a review from francinum April 6, 2024 13:54
Copy link
Member

@francinum francinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just needs testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants