-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderer: expression_t is always allocated as part of structs, ext->numOps always 0 if ext is invalid #1107
base: master
Are you sure you want to change the base?
Conversation
c906c30
to
40bf242
Compare
efe082c
to
0a88dba
Compare
|
||
// A ext->numOps equals to 0 means empty or invalid expression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting there is such a thing as a valid empty expression, but I don't suppose that's the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an empty expression is invalid, right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a closer look and in fact there are "valid" empty expressions, because the parser is buggy, e.g. ((()))
. Apparently they evaluate to 0. It's not something that should have been accepted though.
c125b4d
to
64587e1
Compare
LGTM |
As far as I know,
expression_t
is always allocated as part of structs (texModInfo_t
,shaderStage_t
),ext->numOps
is always0
ifext
is invalid.