Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qr Code #86

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Qr Code #86

merged 14 commits into from
Oct 7, 2024

Conversation

Princekumarofficial
Copy link
Collaborator

QR Code Scan Facility

mittal-ishaan
mittal-ishaan reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@mittal-ishaan mittal-ishaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few suggestions, but we can discuss on these after we go through the design once

api/views.py Outdated Show resolved Hide resolved
messWebsite/settings.py Outdated Show resolved Hide resolved
qrscan/admin.py Outdated Show resolved Hide resolved
qrscan/models.py


class MessCard(models.Model):
id = models.UUIDField(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this https://github.com/pshrmn/notes/blob/master/django/models.md#primary-keys
maybe we might not need id

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important as anyone can generate an QR with a ID if its like Integer (1, 2, 3....)
Anyone can generate these numbers by guessing but by using this method nobody can do that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss on this.

qrscan/models.py Show resolved Hide resolved
qrscan/models.py Show resolved Hide resolved
qrscan/templates/mess_card.html Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
mittal-ishaan
mittal-ishaan reviewed Oct 4, 2024
View reviewed changes
api/views.py Outdated Show resolved Hide resolved
mittal-ishaan
mittal-ishaan reviewed Oct 4, 2024
View reviewed changes
api/views.py Outdated Show resolved Hide resolved
mittal-ishaan
mittal-ishaan reviewed Oct 4, 2024
View reviewed changes
qrscan/models.py Outdated Show resolved Hide resolved
@mittal-ishaan
Copy link
Collaborator

Right now: Caterer scans QR -> card validation done by portal -> card entry saved and student can eat
Suggested flow: Caterer scans QR -> card validation done by portal -> shows the result to caterer if successful then user details with student image if error then show error -> caterer goes through student picture and details and verifies the card -> card entry saved and student can eat.
thoughts? though this can be done in future PRs

mittal-ishaan
mittal-ishaan approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@mittal-ishaan mittal-ishaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@Princekumarofficial Princekumarofficial merged commit e5638f8 into main Oct 7, 2024
3 checks passed
mittal-ishaan pushed a commit that referenced this pull request Dec 26, 2024
@Princekumarofficial
Qr Code (#86)
b4fa848 
* qr code user view

* Static files fix

* enhance

* update

* remove unncessary code

* Basic QR code app

* qr scan with revbate check

* Added comments and docstrings and improved the logic

* get mess cards added
auto create mess card

* Update migrations

* Fixed bugs

* Some fixes

* More details added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittal-ishaan mittal-ishaan mittal-ishaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Princekumarofficial @mittal-ishaan