[crumbs22] Week 04 Solution #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sora0319
reviewed
Apr 26, 2025
| } | ||
| return (ans_head.next); | ||
| } | ||
| }; |
There was a problem hiding this comment.
c++ 코드는 오랜만에 보는데 java와 다르게 포인터를 써서 주소값을 tmp에 넣어서 하는 것이 차이점으로 보이네요!
sora0319
approved these changes
Apr 26, 2025
sora0319
reviewed
Apr 26, 2025
Comment on lines
20
to
23
| int getMaxDepth(TreeNode* node, int depth = 0) { | ||
| if (!node) | ||
| return (depth); | ||
| return std::max(getMaxDepth(node->left, depth + 1), getMaxDepth(node->right, depth + 1)); |
There was a problem hiding this comment.
depth를 전달하는 메소드를 새로 만드는 것보다 기존의 maxDepth를 활용해서 맨 아래의 node에서 +1을 하여서 올라오는 재귀로 만들면 메모리 용량도 줄이고 조금 더 간단한 코드를 만들 수 있을 것 같네요
There was a problem hiding this comment.
좋은 리뷰 감사합니다 ! 확실히 불필요한 코드인 것 같아요. 기존 함수 활용하는 방향으로 수정해보도록 하겠습니다! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!