-
-
Notifications
You must be signed in to change notification settings - Fork 248
[wozlsla] WEEK 03 solutions #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hyogshin 리뷰 및 승인 부탁드립니다 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다. 다음주도 화이팅 :)
|
||
class Solution: | ||
def combinationSum(self, candidates: List[int], target: int) -> List[List[int]]: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
candidates.sort()를 함수 시작 부분에 추가하면 불필요한 탐색을 줄일 수 있음
|
||
# 기저조건 2 | ||
if total == target: # sum to target 찾음 | ||
result.append(nums[:]) # 복사본 추가 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nums[:] 복사 대신 list(nums)도 동일한 효과를 내며 가독성이 조금 좋아질 것 같습니다
for i in range(len(nums)): # O(N) | ||
for j in range(i, len(nums)): # O(N) | ||
|
||
max_total = max(sum(nums[i : j + 1]), max_total) # O(N) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sum()이 매번 새로 계산돼서 비효율적일 것 같습니다
답안 제출 문제
작성자 체크 리스트
In Review
로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!