[혜준] Week1 문제 풀이 #308
Merged
[혜준] Week1 문제 풀이 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요, 코치 Helena 입니다. |
bky373
reviewed
Aug 16, 2024
|
|
||
| const set = new Set(nums); | ||
|
|
||
| return nums.length !== set.size ? true : false; |
There was a problem hiding this comment.
오 간결한 풀이네요!
매우 사소한 의견이지만, 삼항 연산자를 사용하지 않아도 될 것 같습니다!
There was a problem hiding this comment.
return nums.length !== set.size;
넵! 이해했습니다. 의견 감사합니다!
bky373
reviewed
Aug 16, 2024
palindromic-substrings/hyejjun.js
Outdated
| /* | ||
| Time Complexity : O(n^2) | ||
| Space Complexity: O(1) | ||
| */ |
There was a problem hiding this comment.
파일 마지막에 line break 추가 부탁드립니다!
사용하시는 에디터를 잘 모르지만, 에디터 설정에서 자동 적용 기능이 있는지 찾아보시면 좋을 것 같습니다!
HC-kang
approved these changes
Aug 17, 2024
| let val = n.toString(2); | ||
|
|
||
| let res = 0; | ||
| [...val].forEach((val) => res += parseInt(val)) |
There was a problem hiding this comment.
안녕하세요 @hyejjun 님!
해당 코드에서는 사용자가 직접 toString(2)로 2진수로 변환한 안전한 문자열이므로 parseInt(val)�은 굳이 사용하지 않아도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
초안입니다. (복잡도 분석 후 추가 예정)