[jaejeong1] WEEK 01 solutions #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaejeong1
commented
Aug 15, 2024
•
jaejeong1
commented
- Contains Duplicate #217
- Number of 1 Bits #232
- Top K Frequent Elements #237
- Kth Smallest Element In a Bst #252
- Palindromic Substrings #267
|
코드 마지막 라인에 line break 추가해주시면 좋을 것 같습니다! |
| .toArray(); | ||
|
|
||
| // 배열에서 상위 k개만 반환 | ||
| return Arrays.copyOf(sortedNums, k); |
There was a problem hiding this comment.
재밌는 코드 잘 보았습니다 : )
풀이에 영향이 있는건 아니지만 궁금한 부분이 있어서 질문드립니다!
// 빈도순 정렬 후 상위 k개만 배열로 반환
return freq.keySet().stream()
.sorted((a, b) -> freq.get(b) - freq.get(a))
.mapToInt(i -> i)
.limit(k)
.toArray();이런식으로 limit 을 걸어줘도 됐을 것 같은데
혹시 Arrays.copyOf를 추가적으로 사용하신 이유가 있으신지 궁금합니다 : )
There was a problem hiding this comment.
좋은 피드백 감사합니다. 두 방법 모두 결과는 같으나
copyOf 사용 시 새 배열 생성으로 인해 불필요한 메모리를 낭비 및 성능적 단점이 있어 보이네요 :)
제안주신 방법이 더 나은 방안으로 보여 피드백 적용해보겠습니다!!
taekwon-dev
reviewed
Aug 17, 2024
Comment on lines
+18
to
+23
| return freq.keySet().stream() | ||
| .sorted((a, b) -> freq.get(b) - freq.get(a)) | ||
| .mapToInt(i -> i) | ||
| .limit(k) // 배열에서 상위 k개만 반환 | ||
| .toArray(); | ||
| } |
There was a problem hiding this comment.
Stream 사용하니까 엄청 직관적으로 정렬 시킬 수 있네요.. 👍
There was a problem hiding this comment.
네 맞습니다!! 스트림의 장점인것 같아요 ㅎㅎ
DaleSeo
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.