Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[khyo] Week 5 #880

Merged
merged 1 commit into from
Jan 12, 2025
Merged

[khyo] Week 5 #880

merged 1 commit into from
Jan 12, 2025

Conversation

HiGeuni
Copy link
Contributor

@HiGeuni HiGeuni commented Jan 11, 2025 •
edited
Loading

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HiGeuni HiGeuni requested a review from HerrineKim January 11, 2025 11:17
@HiGeuni HiGeuni requested a review from a team as a code owner January 11, 2025 11:17
@github-actions github-actions bot added the js label Jan 11, 2025
EgonD3V
EgonD3V reviewed Jan 12, 2025
View reviewed changes
group-anagrams/higeuni.js
const map = new Map();

for(const str of strs) {
const sortedStr = str.split('').sort().join('');
Copy link
Contributor

@EgonD3V EgonD3V Jan 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 라인이 시간복잡도 측면에서 핵심인 것 같은데, 다른 방식으로 key를 생성하면 시간복잡도를 줄일 수 있을 것 같습니다. 예를 들어 알파벳이니까 굳이 정렬을 안해도 a-z의 빈도를 나타내는 문자열로 변환하거나 할 수 있을 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 감사합니다!

EgonD3V
EgonD3V approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 주도 수고 많으셨습니다. 다음 주도 화이팅!

@HiGeuni HiGeuni merged commit dcbbef5 into DaleStudy:main Jan 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgonD3V EgonD3V EgonD3V approved these changes

@HerrineKim HerrineKim Awaiting requested review from HerrineKim

Assignees

@HiGeuni HiGeuni

Labels
js
Projects
리트코드 스터디 3기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiGeuni @EgonD3V