Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[donghyeon95] Week5 #881

Merged
merged 7 commits into from
Jan 12, 2025
Merged

[donghyeon95] Week5 #881

merged 7 commits into from
Jan 12, 2025

Conversation

donghyeon95
Copy link
Contributor

@donghyeon95 donghyeon95 commented Jan 11, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@donghyeon95 donghyeon95 requested a review from a team as a code owner January 11, 2025 13:15
@github-actions github-actions bot added the java label Jan 11, 2025
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 주도 수고 많으셨습니다. 다음주도 화이팅!

return hm.values().stream().toList();
}

public String rearangeStr (String str) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public String rearangeStr (String str) {
public String reArrangeStr (String str) {

FYI: 오타가 있는 것 같습니다

@@ -0,0 +1,29 @@
import java.util.HashMap;

class Trie {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트라이 자료구조는 트리의 일종인데 노드를 구현하지 않으신 것 같습니다. 노드를 이용해서 구현해보시는 걸 추천드립니다.

import java.util.List;
import java.util.stream.Collectors;

class Solution {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실 이 문제는 implement-trie-prefix-tree에서 구현한 트라이 자료구조와 연관이 있는 문제여서, 트라이를 사용해서 풀어보시면 도움이 되실 것 같습니다.

@TonyKim9401 TonyKim9401 merged commit d688a25 into DaleStudy:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants