Skip to content

[jungsiroo] Week 06 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2025
Merged

[jungsiroo] Week 06 #888

merged 4 commits into from
Jan 17, 2025

Conversation

jungsiroo
Copy link
Contributor

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jungsiroo jungsiroo requested a review from bus710 January 12, 2025 06:43
@jungsiroo jungsiroo requested a review from a team as a code owner January 12, 2025 06:43
@github-actions github-actions bot added the py label Jan 12, 2025
from collections import deque

"""
BFS의 아이디어를 차용하여 풀이
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

풀이와 분석이 깔끔하고 헬퍼함수의 분리가 잘 되어 있는 것 같습니다 :)

이건 간단한 회전변환행렬을 이용한 예전 제 풀이인데, 혹시 관심 있으실까봐 남깁니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 행렬곱은 생각을 못했네요! 감사합니다~

Comment on lines +16 to +21
chars = {'(':1, '{':2, '[':3, ')':-1, '}':-2, ']':-3}
stack = []

for char in s:
if chars[char] > 0:
stack.append(char)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분이 좋네요!
value에 정수값을 두니까 조건문이 간단해져서 편해보입니다 :)

Copy link
Contributor

@obzva obzva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 주 수고하셨습니다

@bus710
Copy link
Contributor

bus710 commented Jan 17, 2025

Solving이어서 맘 놓고 있다가 지금 들어왔는데, 벌써 좋은 리뷰가 달렸네요 ^^;

@obzva
Copy link
Contributor

obzva commented Jan 17, 2025

@bus710 더 좋은 리뷰를 남겨주시면 되죠~!

@bus710
Copy link
Contributor

bus710 commented Jan 17, 2025

앞으로 잘 하겠습니다... ㅎㅎ

@jungsiroo jungsiroo merged commit a41c907 into DaleStudy:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants