[thispath98] Week 6 #895
Merged
[thispath98] Week 6 #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Jan 17, 2025
There was a problem hiding this comment.
아하핳... 저도 처음에 이렇게 풀었었는데, 문제에 숨은 의도를 좀 더 파악해 보는것도 괜찮을것 같아요!
TonyKim9401
reviewed
Jan 17, 2025
Comment on lines
+31
to
+34
| if stack: | ||
| return False | ||
| else: | ||
| return True |
There was a problem hiding this comment.
return 시 stack의 사이즈를 비교하는 걸로 하면 한줄로 줄일 수 있을것 같아요!
TonyKim9401
approved these changes
Jan 17, 2025
KwonNayeon
reviewed
Jan 18, 2025
Comment on lines
+17
to
+34
| stack = [] | ||
| for ch in s: | ||
| if ch in ["(", "{", "["]: | ||
| stack.append(ch) | ||
| elif ch in [")", "}", "]"]: | ||
| if stack and ( | ||
| (ch == ")" and stack[-1] == "(") | ||
| or (ch == "}" and stack[-1] == "{") | ||
| or (ch == "]" and stack[-1] == "[") | ||
| ): | ||
| stack.pop() | ||
| else: | ||
| return False | ||
|
|
||
| if stack: | ||
| return False | ||
| else: | ||
| return True |
There was a problem hiding this comment.
코드가 직관적이라 이해하기 쉬웠습니다! 딕셔너리를 활용하여 코드를 조금 더 간결하게 개선할 수 있을 것 같습니다.
Comment on lines
+3
to
+10
| class Solution: | ||
| def groupAnagrams(self, strs: List[str]) -> List[List[str]]: | ||
| anagram_dict = defaultdict(list) | ||
| for string in strs: | ||
| anagram_dict[tuple(sorted(string))].append(string) | ||
|
|
||
| answer = list(anagram_dict.values()) | ||
| return answer |
There was a problem hiding this comment.
리뷰가 늦어져서 죄송합니다. 저는 if-else문을 활용해서 키가 존재하는지의 여부를 체크했는데, defaultdict(list)를 사용하면 예외처리를 더 간단하게 할 수 있다는 걸 알게 됐습니다! 이번 주도 고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
Week 5 문제들을 PR 하지 못해서 부득이하게 이번주에 포함시켰습니다.
Week 5
Week 6
체크 리스트
In Review로 설정해주세요.