Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helena] Week 9 #998

Merged
merged 5 commits into from
Feb 9, 2025
Merged

[Helena] Week 9 #998

merged 5 commits into from
Feb 9, 2025

Conversation

yolophg
Copy link
Contributor

@yolophg yolophg commented Feb 8, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@yolophg yolophg self-assigned this Feb 8, 2025
@yolophg yolophg requested a review from a team as a code owner February 8, 2025 00:09
@yolophg yolophg requested a review from Chaedie February 8, 2025 00:10
@github-actions github-actions bot added the py label Feb 8, 2025
@yolophg yolophg changed the title solve: linkedListCycle, findMinimumInRotatedSortedArray [Helena] Week 9 Feb 8, 2025
@yolophg yolophg force-pushed the main branch 4 times, most recently from 8fb2b3b to fb9f931 Compare February 8, 2025 00:14
# min could be mid or in the left part
high = mid
# low and high converge to the minimum element
return nums[low]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 같은 방식으로 풀었어요! 주석을 꼼꼼히 달아주셔서, 코드를 처음 읽는 사람도 알고리즘 풀이를 이해하기 쉬울 것 같습니다!

if suffix_product == 0:
suffix_product = 1

return max_product
Copy link
Contributor

@KwonNayeon KwonNayeon Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 각 위치에서 가능한 최소/최대값을 찾는 방식으로 문제를 풀었는데, 양쪽에서 곱해나가는 방식으로 풀 수도 있었네요! 공부가 되었습니다 ㅎㅎ

Copy link
Contributor

@KwonNayeon KwonNayeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yolophg 님 풀이를 통해 새로운 방식에 대해서 알 수 있었습니다. 이번 주도 고생하셨습니다 👍
제가 지정된 리뷰어가 아닌데, 모르고 승인을 눌렀네요... 변경하는 법을 몰라서 이렇게 두겠습니다 😅

@SamTheKorean SamTheKorean merged commit 3f1fab1 into DaleStudy:main Feb 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants