Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task lock logic #394

Merged
merged 14 commits into from
Dec 20, 2023
Merged

Task lock logic #394

merged 14 commits into from
Dec 20, 2023

Conversation

Ishankoradia
Copy link
Contributor

No description provided.

@Ishankoradia Ishankoradia requested a review from fatchat December 19, 2023 03:56
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (c8f8709) 72.39% compared to head (428d44b) 72.15%.
Report is 1 commits behind head on main.

❗ Current head 428d44b differs from pull request most recent head bd4e2fb. Consider uploading reports for the commit bd4e2fb to get more accurate results

Files Patch % Lines
ddpui/ddpprefect/prefect_service.py 11.76% 15 Missing ⚠️
ddpui/api/client/prefect_api.py 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   72.39%   72.15%   -0.25%     
==========================================
  Files          64       65       +1     
  Lines        3786     3839      +53     
==========================================
+ Hits         2741     2770      +29     
- Misses       1045     1069      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit 900c9f6 into main Dec 20, 2023
1 check failed
@fatchat fatchat deleted the task-lock-logic branch December 20, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants