Fix #185 - tighten up adjustment of reminder dates implied to be tomorrow #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If only a time is provided but it is in the past, shunt it to tomorrow (fixes DamascenoRafael#185) - If (for some exceedingly obscure reason...) a user explicitly provides the current year, don't override it with next year!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only a time is provided, but it is in the past, assume tomorrow. For example, if it is currently noon but a user states "8am". This fixes:
In addition, if a reminder is placed in the past with an explicit year (e.g. it is June 2024 and the user provides "Feb 2 2024"), the date is not overridden with the next year. (Bit of an obscure fix, but it didn't hurt to add while I was in the area!)