Allow priority setting, both from picker and parsed via !!! #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes use of new dependency WrappingHStack to ensure that date, time and priority don't get squooshed. Rather than use a picker (which didn't really look too stylish!) the user clicks to cycle None -> Low -> Medium -> High; the icon updates too.
Entirely functional! That said, if you type too many !s, or type a ! and then delete it, it lingers with a priority, which is a little annoying.
|
@yunruse Hey, I would do it myself but not a swift programmer, so mostly asking if that would interest you. Thanks |
|
@AndreaHasani I've never coded in Swift before! It was quite fun; I just sort of cribbed the parser by looking at the interface used in other parsers and hashing out the Swift sufficient to meet the needs here. Swift is pretty elegant so it's not the worst to learn! Sadly EventKit's EKReminder doesn't have any API for tagging reminders :/ |
|
Very nice addition indeed ! I fully support it for the next release (tested and it works like a charm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 'priority' pill to the editor, making use of the dependency WrappingHStack to ensure that this doesn't squoosh up with the date and time pickers. A PriorityParser is added – rather similar to the other Parser objects – so "!!" can be used to impart a priority on the reminder, thereby fixing #195.
ss.2024-06-14.at.00.33.38.mov
This was rather fun to work on 😅 I hope this barrage of pull requests isn't annoying!