Make link in titles clickable #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DamascenoRafael, this is my attempt to make links in titles of items clickable. I am not a swift developer so this has been heavily inspired by AI code generator and may not be the best approach to do this. However I didn't want to just ask for this feature without trying to help out. Keen to hear your thoughts on this. Tested this locally. Highlighting of links + clickthrough seemed to work but haven't really gone through all the edge cases. |
psiman-wandera
force-pushed
the
clickable_links
branch
from
e813cca
to
73094b2
Compare
psiman-wandera
force-pushed
the
clickable_links
branch
from
73094b2
to
77f037d
Compare
|
This would be a very nice addition indeed ! I tested it as well, and it works pretty well in most of the reminders I had with links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parsing of titles to detect link and make them clickable.