-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support runtime property attributes via TypeDescriptor #53
Support runtime property attributes via TypeDescriptor #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this. A few small requests.
BTW: Is the dependency on version |
This is fine. It's the latest version and supports Feel free to bump the version in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to bump version to 0.9.0
.
Please don't yet merge, I think I found a double-report of validation errors for normal attributes. |
Anyway, with the previous commit the static attributes are now only considered once. |
|
@warappa is this ready to go then? |
@DamianEdwards Yes, it's ready |
This adds support for property attributes configured via
TypeDescriptor
.The code for
PropertyOverridingTypeDescriptor
is taken from StackOverflow as stated in the comment.This should fix #52.