Revert "Hash#update() vs Hash#[]=" - issues with tests and high poten…

…tial for naming conflicts with AR methods

This reverts commit dc7a28c.

.fasterer.yml

@@ -12,7 +12,6 @@ speedups:
   fetch_with_argument_vs_block: true
   keys_each_vs_each_key: true
   hash_merge_bang_vs_hash_brackets: true
-  hash_update_vs_hash_brackets: true
   block_vs_symbol_to_proc: true
   proc_call_vs_yield: true
   gsub_vs_tr: true

README.md

@@ -68,7 +68,6 @@ speedups:
   fetch_with_argument_vs_block: true
   keys_each_vs_each_key: true
   hash_merge_bang_vs_hash_brackets: true
-  hash_update_vs_hash_brackets: true
   block_vs_symbol_to_proc: true
   proc_call_vs_yield: true
   gsub_vs_tr: true

lib/fasterer/offense.rb

@@ -52,9 +52,6 @@ def explanation
       hash_merge_bang_vs_hash_brackets:
         'Hash#merge! with one argument is slower than Hash#[]',
 
-      hash_update_vs_hash_brackets:
-        'Hash#update with one argument is slower than Hash#[]',
-
       block_vs_symbol_to_proc:
         'Calling argumentless methods within blocks is slower than using symbol to proc',
 

lib/fasterer/scanners/method_call_scanner.rb

@@ -39,8 +39,6 @@ def check_offense
         check_fetch_offense
       when :merge!
         check_merge_bang_offense
-      when :update
-        check_update_offense
       when :last
         check_last_offense
       when :include?
@@ -154,17 +152,6 @@ def check_merge_bang_offense
       end
     end
 
-    def check_update_offense
-      return unless method_call.arguments.count == 1
-
-      first_argument = method_call.arguments.first
-      return unless first_argument.type == :hash
-
-      if first_argument.element.drop(1).count == 2 # each key and value is an item by itself.
-        add_offense(:hash_update_vs_hash_brackets)
-      end
-    end
-
     def check_last_offense
       return method_call unless method_call.receiver.is_a?(MethodCall)